Skip to content

refactor: Improve policy overview form layout and styling - #101

Merged
carhartlewis merged 2 commits into
mainfrom
devin/1741119397-add-required-policy
Mar 4, 2025
Merged

carhartlewis merged 2 commits into
mainfrom
devin/1741119397-add-required-policy

Conversation

@carhartlewis

@carhartlewis carhartlewis commented Mar 4, 2025 •

Copy link
Copy Markdown
Contributor
  • Adjust grid layout for review date and signature requirement fields
  • Add padding and improve button styling
  • Enhance form field spacing and alignment
  • Maintain existing functionality while improving visual consistency

Summary by CodeRabbit

  • Style
    • Enhanced internal code formatting and alignment for improved consistency and readability. These cosmetic adjustments do not affect the functionality or user experience.

- Adjust grid layout for review date and signature requirement fields
- Add padding and improve button styling
- Enhance form field spacing and alignment
- Maintain existing functionality while improving visual consistency
@vercel

vercel Bot commented Mar 4, 2025 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2025 9:44pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
comp-portal ⬜️ Skipped (Inspect) Mar 4, 2025 9:44pm
web ⬜️ Skipped (Inspect) Mar 4, 2025 9:44pm

@coderabbitai

coderabbitai Bot commented Mar 4, 2025 •

Copy link
Copy Markdown

Warning

Rate limit exceeded

@carhartlewis has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 4 minutes and 25 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 1ef9c80 and 91db6eb.

📒 Files selected for processing (1)
  • apps/app/src/components/forms/policies/create-policy-comment-form.tsx (1 hunks)

Walkthrough

The pull request involves cosmetic formatting changes in the policy-overview.tsx file. The code indentation has been adjusted to a consistent style without modifying any functionality, logic, or the declarations of exported entities.

Changes

File Change Summary
apps/app/.../policy-overview.tsx Adjusted code indentation for improved readability.

Poem

In a code garden neat and fine,
I hop through lines with rhythmic design.
Each indent aligned like a row of treats,
A tidy code trail where order repeats.
This rabbit cheers the tweaks so divine!


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

- Correct import path for createPolicyCommentAction
- Move action from policies to policy directory
- Maintain existing functionality with updated import
@vercel
vercel Bot temporarily deployed to Preview – web March 4, 2025 21:41 Inactive
@vercel
vercel Bot temporarily deployed to Preview – comp-portal March 4, 2025 21:41 Inactive
@carhartlewis
carhartlewis merged commit 722422e into main Mar 4, 2025
tofikwest added a commit that referenced this pull request Oct 2, 2026
…, GH-79, GH-78, GH-53, GH-54 (#3576)

* fix(mcp-server): bind serve to localhost and reject foreign origins

GH-273: the streamable HTTP server bound 0.0.0.0 with
Access-Control-Allow-Origin: * and no request authentication, so any
website the operator visited could drive the local MCP server with the
CLI-configured API key, and the LAN could reach it too.

- bind to 127.0.0.1 by default (new --host flag to opt out)
- drop the wildcard CORS middleware (MCP HTTP clients are not browsers)
- reject POST /mcp with a non-localhost Origin header (browsers always
  send one; header-less local MCP clients keep working with --apikey)

* fix(portal): scope policy signature and pdf endpoints to caller's org

GH-93 / GH-79 / GH-245: portal policy endpoints looked policies and
policy versions up by bare id with no organization scoping, letting any
authenticated portal user sign policies in other tenants or fetch a
presigned URL for another org's policy PDF.

- mark-policy-completed: resolve the member within the policy's
  organization (also fixes the arbitrary-membership pick for
  multi-org users)
- accept-policies: skip policies outside the member's organization
- policy-pdf-url: scope the versionId lookup to the policy whose org
  membership was already validated

* fix(security): mask all text and media in sentry session replay

GH-101: session replay ran in production with maskAllText: false and
blockAllMedia: false while the sentry-mask escape hatch was used in zero
of ~1470 components, recording customer compliance data verbatim.

Default to masking everything; data-sentry-unmask is now the opt-in for
elements provably safe to record.

* fix(email): remove hardcoded fallback secret for unsubscribe tokens

GH-100: the unsubscribe-token HMAC key silently fell back to the public
literal 'fallback-secret' when neither UNSUBSCRIBE_SECRET nor AUTH_SECRET
was set, and apps/api (which never sets either) verifies the
unauthenticated POST /v1/email/unsubscribe endpoint with it, making every
token forgeable from source.

Resolve the secret lazily and fail closed: generating a token without a
configured secret now throws. Documented UNSUBSCRIBE_SECRET in
apps/api/.env.example.

* fix(api): validate organizationId before building upstash vector filters

GH-103: findSimilarContent and findSimilarContentBatch interpolated
organizationId into the Upstash Vector metadata filter with no escaping,
so a value containing a quote could append arbitrary filter clauses
(e.g. OR organizationId GLOB "*") and dump every tenant's RAG chunks.

Allowlist the prefixed-CUID shape and fail closed before the filter
string is built, in both query paths and the sync readiness check.
Adds regression tests for the literal exploit payload.

* fix(api): honor securityQuestionnaireEnabled on token questionnaire upload

GH-78: POST /v1/questionnaire/parse/upload/token validated the trust
access token and ran RAG auto-answering without checking
Trust.securityQuestionnaireEnabled, so an org that disabled the AI
questionnaire was still fully served by any token holder.

Check the flag after token validation and return 403 when disabled;
defaults to enabled when no Trust row exists, matching the public
overview helper's semantics.

* fix(api): scope organization logo keys to the owning organization

GH-53: UpdateOrganizationDto.logo accepted any string, it was stored
verbatim, and GET /v1/organization presigned it as a raw S3 key against
the shared org-assets bucket - a cross-tenant read of any known key.

Reject logo keys not prefixed with the organization's own id on update,
refuse to presign out-of-org keys on read, and skip presigning
out-of-org logos in the app layout.

* fix(api): reject cross-organization fileKeys in evidence form submissions

GH-54: evidence form file fields accepted any non-empty fileKey, stored
it verbatim, and the submissions read path presigned it against the
shared attachments bucket - a cross-tenant read given a leaked key.

Validate every submitted fileKey against the caller's organization
prefix on create, and skip presigning out-of-org keys when refreshing
download URLs on read (defense in depth for legacy rows).

* fix(app): verify run ownership in task status route via org tags

GH-257: GET /api/tasks/[taskId]/status returned any Trigger.dev run's
output to any authenticated user with no ownership check, exposing other
tenants' AI-generated policy, questionnaire, and vendor content to
whoever learned a run id.

Tag every user-triggerable tasks.trigger call with the owning
organization id and require a matching tag before returning run data;
mismatches get the same 404 as a missing run. research-vendor runs are
tagged when an active org exists (its output is shared, not tenant
data). Adds route tests for the cross-tenant and untagged cases.

* fix: refine access checks and legacy MCP maintenance

* fix(security): address review feedback on csv export, batch fix tags and run status rbac

- exportCsv skips presigning fileKeys outside the organization prefix
- derive the batch fix run tag from the created batch, not caller input
- require task:read on the task run status route

---------

Co-authored-by: tofikwest <tofik@trycomp.ai>

This branch was successfully deployed

1 active and 2 inactive deployments
Preview – app — 91db6ebc Deployed Mar 4, 2025 by vercel[bot]
Preview – web — 91db6ebc Deployed Mar 4, 2025 by vercel[bot]
Preview – comp-portal — 91db6ebc Deployed Mar 4, 2025 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant